Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galleria: Next & Previous Buttons role #16446

Closed
e-matthaey opened this issue Sep 27, 2024 · 0 comments · Fixed by #16442
Closed

Galleria: Next & Previous Buttons role #16446

e-matthaey opened this issue Sep 27, 2024 · 0 comments · Fixed by #16442
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.13

Comments

@e-matthaey
Copy link
Contributor

Describe the bug

To improve accessibility of the galleria component, the following points should be adjusted:

  • next & previous buttons are not allowed to have a role="navigation"
  • both buttons need an aria-label

primeng-galleria

Environment

Angular > 18
PrimeNG > 17

Reproducer

No response

Angular version

18

PrimeNG version

17.18.10

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@e-matthaey e-matthaey added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 27, 2024
@e-matthaey e-matthaey mentioned this issue Sep 27, 2024
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
@mertsincan mertsincan linked a pull request Nov 18, 2024 that will close this issue
galleria/fix: removed role navigation on buttons and added arialabels #16442
Merged
@mertsincan mertsincan moved this to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

galleria/fix: removed role navigation on buttons and added arialabels e-matthaey/primeng
2 participants
@mertsincan @e-matthaey