Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleButton: Incorrect Property Used in hasOffLabel Getter #16916

Closed
navedqb opened this issue Dec 3, 2024 · 0 comments · Fixed by #16917
Closed

ToggleButton: Incorrect Property Used in hasOffLabel Getter #16916

navedqb opened this issue Dec 3, 2024 · 0 comments · Fixed by #16917
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
17.18.13

Comments

@navedqb
Copy link
Contributor

navedqb commented Dec 3, 2024

Describe the bug

The hasOffLabel getter is incorrectly using onLabel instead of offLabel to determine its value.

Environment

primeng v17.18.12

Reproducer

No response

Angular version

17.3.12

PrimeNG version

17.18.12

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v22.11.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@navedqb navedqb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 3, 2024
@navedqb navedqb mentioned this issue Dec 3, 2024
Merged
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 4, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

fix incorrect property used in hasOffLabel getter qburst/primeng-1
2 participants
@mertsincan @navedqb