Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0.0-rc.2 : Table's Column Filter drop-down is cut off when it's length exceeds height of the table #16943

Closed
mplgn opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mplgn
Copy link

mplgn commented Dec 5, 2024

Describe the bug

When using a Column Filter on a Table Column, if the height of the filter's drop-down exceeds the height of the table, the drop-down (and thus filter options) get cut off.

Stackblitz link is provided below to demonstrate and reproduce this.

Works correctly (because table height is greater than height of the filter drop-down):
image

Broken: filtered data contains just one row, which makes the table height less than the drop-down height, and the filter items get cut off:
image

Environment

Angular v18 + PrimeNG 18 rc.2
macOS Sequoia
Webstorm 2024.3

Reproducer

https://stackblitz.com/edit/stackblitz-starters-87smrn?file=src%2Fapp%2Ftable-basic-demo%2Ftable-basic-demo.component.html

Angular version

18.2.0

PrimeNG version

18.0.0-rc.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.17.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the Stackblitz demo
  2. Click on the filter in the Category column
  3. Observe all filter items are visible
  4. Select the "Fitness" filter item
  5. Observe only the single row in the table is now visible
  6. Click on the filter in the Category column
  7. Observe that the drop-down is cut off and not all filter items are visible.
image

Expected behavior

All filter items should be visible regardless of the height of the table.

@mplgn mplgn added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Dec 11, 2024
@mehmetcetin01140
Copy link
Contributor

Hi, you can resolve the issue by adding appendTo="body" to the select component. I'm closing the issue.

Example: https://stackblitz.com/edit/stackblitz-starters-gvb2bw4y?file=src%2Fapp%2Ftable-basic-demo%2Ftable-basic-demo.component.html

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 12, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

3 participants