Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribution Page for v18 #17038

Closed
shawnweeks opened this issue Dec 12, 2024 · 0 comments
Closed

Update Contribution Page for v18 #17038

shawnweeks opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@shawnweeks
Copy link

Describe the bug

Currently the contribution page https://primeng.org/contribution is completely wrong for v18 and the instructions don't work. v18 requires pnpm instead of npm and you can't just run ng serve in the root directory of the project you've got to switch to the apps/showcase directory.

Here is what I had to do instead to run the v18 showcase.

git clone https://github.com/primefaces/primeng.git
cd primeng

npm run setup
cd apps/showcase
ng serve

Environment

N/A

Reproducer

No response

Angular version

18.x.x

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.15.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@shawnweeks shawnweeks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 12, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 13, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Dec 13, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 13, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 18.0.1 milestone Dec 13, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants