Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table: p-columnFilter set to date errors & drops a deprecation warning #17094

Closed
thatoneprogrammer111 opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@thatoneprogrammer111
Copy link

Describe the bug

<p-columnFilter type="date" field="creationDate">Creation Date</p-columnFilter>

will cause this deprecation warning, likely because the calendar is still used internally right here

Calendar component is deprecated as of v18, use DatePicker component instead.

and additionally cause this Error:

ERROR TypeError: can't access property "addEventListener", element is undefined
    Angular 4
    bindDocumentResizeListener primeng-calendar.mjs:4691
core.mjs:6642:18
    Angular 53
    RxJS 6
    Angular 46
    Calendar_ng_template_2_Template primeng-calendar.mjs:718
    Angular 12
    Calendar_Template primeng-calendar.mjs:4904
    executeTemplate Angular

#16354 has mentioned it saying this is fixed. This might has to do with me being on the 19.0.0-rc.1 version..?

Environment

dev

Reproducer

No response

Angular version

19.0.4

PrimeNG version

19.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.12.2

Browser(s)

Firefox Developer Edition, haven't tested on other browsers

Steps to reproduce the behavior

The actual error occurs upon opening the actual filter popup, the warning whenever the component is initialized.

Expected behavior

Not drop the warning/error

@thatoneprogrammer111 thatoneprogrammer111 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 17, 2024
@thatoneprogrammer111 thatoneprogrammer111 changed the title p-columnFilter set to date errors & drops a deprecation warning p-table: p-columnFilter set to date errors & drops a deprecation warning Dec 17, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 17, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 17, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 17, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

4 participants