Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileupload missing import in documentation #9618

Closed
andonary opened this issue Dec 6, 2020 · 0 comments
Closed

fileupload missing import in documentation #9618

andonary opened this issue Dec 6, 2020 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@andonary
Copy link

andonary commented Dec 6, 2020

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

hi there,

this is not a big issue but I think the documentation should mention to import HttpClientModule from @angular inside the documentation :
https://primefaces.org/primeng/showcase/#/fileupload

There is no mention of importing in app.module we should import HttpClientModule. If it is not present, nothing is displayed.

  • Angular version: 11.0.2
  • PrimeNG version: 5.X
  • Browser: [Safari]
  • Language: [TypeScript 4.0.2]
@yigitfindikli yigitfindikli self-assigned this Dec 7, 2020
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 7, 2020
@yigitfindikli yigitfindikli added this to the 11.0.1 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants