-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional color variables from Primer Primitives to the theme #1074
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/3QotiQcdjH2ncC9TUXbK34SHcv7m |
b9cc84d
to
b78b8f0
Compare
Co-authored-by: Cole Bemis <[email protected]>
@colebemis thank you so much for sending me that refactor! Your code was definitely a big improvement in readability, using |
Turns out preval was silently not working because it doesn't parse TypeScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
First item in https://github.com/github/design-systems/issues/1219
This PR deep merges in primer primitives into our theme colors and also separates out colors from compound css statements.