From 2eabfdea85667c041e86e13376f1d2823b64fcb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nikola=20Stamatovi=C4=87?= Date: Tue, 7 May 2024 16:18:57 +0200 Subject: [PATCH] [a11y] Removing `!important` from `letter-spacing` marketing typography (#2613) * removing !important from letter-spacing marketing typography * Create proud-rockets-kiss.md --------- Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> --- .changeset/proud-rockets-kiss.md | 5 +++++ src/marketing/type/typography.scss | 12 ++++++------ 2 files changed, 11 insertions(+), 6 deletions(-) create mode 100644 .changeset/proud-rockets-kiss.md diff --git a/.changeset/proud-rockets-kiss.md b/.changeset/proud-rockets-kiss.md new file mode 100644 index 0000000000..df5429d85a --- /dev/null +++ b/.changeset/proud-rockets-kiss.md @@ -0,0 +1,5 @@ +--- +"@primer/css": patch +--- + +removing !important from letter-spacing marketing typography diff --git a/src/marketing/type/typography.scss b/src/marketing/type/typography.scss index 2640c48785..09e9b22a57 100644 --- a/src/marketing/type/typography.scss +++ b/src/marketing/type/typography.scss @@ -10,7 +10,7 @@ font-feature-settings: $mktg-font-feature-settings; // stylelint-disable-next-line primer/typography font-weight: $mktg-header-weight-default !important; - letter-spacing: $mktg-header-spacing-default !important; + letter-spacing: $mktg-header-spacing-default; } @each $header, $sizes in $mktg-headers { @@ -30,7 +30,7 @@ line-height: map-get($pairing-md, 'lh') !important; @if (map-get($pairing-md, 'size') >= $mktg-header-spacing-threshold and map-get($pairing, 'size') < $mktg-header-spacing-threshold) { - letter-spacing: $mktg-header-spacing-large !important; + letter-spacing: $mktg-header-spacing-large; } @if (map-get($pairing-md, 'size') >= $mktg-header-weight-threshold and map-get($pairing, 'size') < $mktg-header-weight-threshold) { @@ -45,7 +45,7 @@ line-height: map-get($pairing-lg, 'lh') !important; @if (map-get($pairing-lg, 'size') >= $mktg-header-spacing-threshold and map-get($pairing-md, 'size') < $mktg-header-spacing-threshold) { - letter-spacing: $mktg-header-spacing-large !important; + letter-spacing: $mktg-header-spacing-large; } @if (map-get($pairing-lg, 'size') >= $mktg-header-weight-threshold and map-get($pairing-md, 'size') < $mktg-header-weight-threshold) { @@ -77,7 +77,7 @@ font-size: map-get($pairing, 'size') !important; line-height: map-get($pairing, 'lh') !important; - @if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large !important; } + @if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large; } @if (map-get($pairing, 'size') >= $mktg-body-weight-threshold) { font-weight: $font-weight-semibold; } @@ -87,7 +87,7 @@ line-height: map-get($pairing-md, 'lh') !important; @if (map-get($pairing-md, 'size') >= $mktg-body-spacing-threshold and map-get($pairing, 'size') < $mktg-body-spacing-threshold) { - letter-spacing: $mktg-body-spacing-large !important; + letter-spacing: $mktg-body-spacing-large; } @if (map-get($pairing-md, 'size') >= $mktg-body-weight-threshold and map-get($pairing, 'size') < $mktg-body-weight-threshold) { @@ -102,7 +102,7 @@ line-height: map-get($pairing-lg, 'lh') !important; @if (map-get($pairing-lg, 'size') >= $mktg-body-spacing-threshold and map-get($pairing-md, 'size') < $mktg-body-spacing-threshold) { - letter-spacing: $mktg-body-spacing-large !important; + letter-spacing: $mktg-body-spacing-large; } @if (map-get($pairing-lg, 'size') >= $mktg-body-weight-threshold and map-get($pairing-md, 'size') < $mktg-body-weight-threshold) {