Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete.Input does not allow value to be set to empty string "" #1995

Closed
Swiftwork opened this issue Mar 24, 2022 · 3 comments
Closed

Autocomplete.Input does not allow value to be set to empty string "" #1995

Swiftwork opened this issue Mar 24, 2022 · 3 comments
Labels
Stale

Comments

@Swiftwork
Copy link
Contributor

Describe the bug
If the value is explicitly set to an empty string from the parent on the Autocomplete.Input it won't clear the text in the field.

To Reproduce
Line 149 in AutocompleteInput.tsx

Expected behavior
It should either allow empty strings or change the operation to be setInputValue(value || '').

Desktop (please complete the following information):

  • OS: All
  • Browser: All
  • Version: 35.1.0

Smartphone (please complete the following information):

  • Device: All
  • OS: All
  • Browser: All
  • Version: 35.1.0
@Swiftwork
Copy link
Contributor Author

PR created: #2127

@Swiftwork Swiftwork mentioned this issue Jun 20, 2022
Closed
6 tasks
@github-actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 17, 2022
@Swiftwork
Copy link
Contributor Author

Closed by: #2154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autocomplete: allow "falsely" input values
1 participant
@Swiftwork