Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseStyles warning #5689

Open
nazarifard opened this issue Feb 12, 2025 · 1 comment
Open

BaseStyles warning #5689

nazarifard opened this issue Feb 12, 2025 · 1 comment
Labels
bug Something isn't working react

Comments

@nazarifard
Copy link

nazarifard commented Feb 12, 2025

Description

Image

warning message:
styled-components: it looks like an unknown prop "lineHeight" is being sent through to the DOM, which will likely trigger a React console error. If you would like automatic filtering of unknown props, you can opt-into that behavior via <StyleSheetManager shouldForwardProp={...}> (connect an API like @emotion/is-prop-valid) or consider using transient props ($ prefix for automatic filtering.)

Steps to reproduce

import React from 'react';
import ReactDOM from 'react-dom/client';
import { BaseStyles, ThemeProvider } from '@primer/react';
const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement); 
root.render(
  <React.StrictMode>
  <ThemeProvider>
    <BaseStyles>
    </BaseStyles>
  </ThemeProvider>
</React.StrictMode>,
);

Version

v37.12.0

Browser

Chrome, Edge

@nazarifard nazarifard added the bug Something isn't working label Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Uh oh! @nazarifard, at least one image you shared is missing helpful alt text. Check your issue body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 2

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

No branches or pull requests

1 participant