Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with NotEnough error in arbitrary parsing functions #5

Open
joshtriplett opened this issue Sep 7, 2020 · 1 comment
Open
Labels
bug Something isn't working

Comments

@joshtriplett
Copy link
Contributor

As far as I can tell, when cbor_event deserializes from a BufRead instance, it only calls fill_buf when calling get (and then only once), not when calling advance. So, any arbitrary parsing function may potentially return a NotEnough error in the middle of its parsing, requiring any higher-level protocol parsing built atop that to handle any parsing function failing with NotEnough and retry after fetching more data.

@NicolasDP NicolasDP added the bug Something isn't working label Sep 7, 2020
@NicolasDP
Copy link
Contributor

Thanks for your contributions and looking into this repo. I'll be looking at them this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants