New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent config key style #17

Closed

dbrgn opened this issue Nov 7, 2021 · 1 comment · Fixed by #21

Assignees

Contributor

dbrgn commented Nov 7, 2021

Right now the launch config contains a mix of under_score and camelCase:

This should be consistent. From looking at https://code.visualstudio.com/docs/cpp/launch-json-reference, camelCase seems to be the convention.

The sooner this is corrected, the better (in order to avoid breaking configs later on) 🙂

Member

Yatekii commented Nov 7, 2021

I agree that we should change this. I think this can easily be done with serde by telling it to camelCase :)

Yatekii assigned noppej

noppej linked a pull request

that will close this issue

Convert launch.json properties to camelCase #21

Merged

bors bot closed this as completed in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment