Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Validation Failed: The year 1918 is outside the accepted range #81

Closed
bkeepers opened this issue Jan 2, 2018 · 4 comments
Closed

Validation Failed: The year 1918 is outside the accepted range #81

bkeepers opened this issue Jan 2, 2018 · 4 comments
Labels

Comments

@bkeepers
Copy link
Contributor

bkeepers commented Jan 2, 2018

From https://sentry.io/probot/stale/issues/427330638/

{
  "message": "Validation Failed",
  "errors": [{
    "message":"The year 1918 in \"1918-01-27T22:55:01\" is outside the accepted range 1970 to 2970.",
    "resource":"Search",
    "field":"q",
    "code":"invalid"
  }],
  "documentation_url":"https://developer.github.com/v3/search/"
}```
@tcbyrd
Copy link
Contributor

tcbyrd commented Jan 3, 2018

I looked through several of these and they're all related to the the PointCloudLibrary/pcl repository. Looks like they changed the days to 100 years, which is still outside of the Unix timestamp range.

@bkeepers I can take a crack at a PR for #79, but will also tell them to update their range to no earlier than 1970. This also relates back to probot/friction#1. This setting is having the desired outcome, but only because the method raises an error which they don't see.

@bkeepers
Copy link
Contributor Author

bkeepers commented Jan 4, 2018

@tcbyrd the other thing we need to do is add guards for the config (#62). For this issue specifically, check that the date is within an acceptable range.

For now, I think stale should just refuse to run if it encounters an invalid config.

@tcbyrd
Copy link
Contributor

tcbyrd commented Jan 4, 2018

Agreed. I was thinking this was the next step, especially given some of the other errors I've seen in sentry revolve around incorrect configs.

@stale
Copy link

stale bot commented Apr 5, 2018

Is this still relevant? If so, please comment with any updates or addition details.

@stale stale bot added the wontfix label Apr 5, 2018
@stale stale bot closed this as completed Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants