Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update p5.js build and release tasks to ES6 #3372

Closed
lmccart opened this issue Dec 11, 2018 · 12 comments
Closed

update p5.js build and release tasks to ES6 #3372

lmccart opened this issue Dec 11, 2018 · 12 comments

Comments

@lmccart
Copy link
Member

lmccart commented Dec 11, 2018

As part of the migration to ES6, the p5.js build and release tasks in the tasks folder need to be checked and updated as needed from ES5 to ES6.

@Spongman
Copy link
Contributor

maybe #3204 will be of some help?

@lmccart lmccart added this to the 0.9.0 milestone Dec 11, 2018
@limzykenneth
Copy link
Member

Is there a timeline/guide/steps for the transition to ES6 in general? I just saw a bunch of ES6 transition issues and PR but have no idea the criteria (in terms of target compatibility) or the priorities other than the milestones tags. Is it possible to draft a document/wiki on github to at least outline compatibility targets and even better a rough timeline?

@lmccart
Copy link
Member Author

lmccart commented Dec 23, 2018

@limzykenneth I just added a document that represents a first draft of a roadmap to 1.0 including ES6 transition, comments welcome on this issue.

In terms of compatibility targets, does this supported browsers doc (needs some updating) address it? Or are you thinking of something else?

@limzykenneth
Copy link
Member

The document is great, I'll have a closer look when I get a chance.

@LakshSingla
Copy link
Contributor

@lmccart I would like to take up this issue, but since there were issues regarding the change of build systems and task runners ( #3409 #3425 ), is this issue still relevant ??

@limzykenneth
Copy link
Member

@LakshSingla For now we haven't reach any complete concensus on the mentioned issues yet (maybe not anytime soon as well), just some experiments going on so this issue is still relevant for now.

@LakshSingla
Copy link
Contributor

@limzykenneth #3451 tackles this issue.

@lmccart
Copy link
Member Author

lmccart commented Feb 18, 2019

closed with #3451

@lmccart lmccart closed this as completed Feb 18, 2019
@limzykenneth
Copy link
Member

I just noticed that although the tasks in the tasks folder are all updated, the Gruntfile.js file isn't fully updated yet.

@lmccart lmccart reopened this Mar 15, 2019
@JaiKotia
Copy link
Contributor

Hey I'd like to take up this issue @lmccart @limzykenneth

@limzykenneth
Copy link
Member

@JaiKotia Go ahead, only Gruntfile.js needs to be updated.

@lmccart
Copy link
Member Author

lmccart commented Mar 21, 2019

closed with #3628

@lmccart lmccart closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants