Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

section.id == 398 is in both street.id == 564 and street.id == 510 #110

Open
vvoovv opened this issue Sep 9, 2024 · 3 comments
Open

section.id == 398 is in both street.id == 564 and street.id == 510 #110

vvoovv opened this issue Sep 9, 2024 · 3 comments

Comments

@vvoovv
Copy link
Member

vvoovv commented Sep 9, 2024

File berlin_karl_marx_allee.osm.

@polarkernel
Copy link
Collaborator

I need to rewrite createSymSideLanes(). There are two consecutive SymLanes at 794 and 795 in the original sections, because these sections change their categories there. Since intersections are processed one by one, to avoid modifying an iterable during the iteration, two Streets are created, each with one SymLane, both containing the Section with the id 398. Additionally, but I do not yet know if this has any influence, the ways change their direction at 795.

To fix this will take some time.

@polarkernel
Copy link
Collaborator

It is impossible to create a Street with sections running in different directions. Therefore, the intersection 795 can't be transformed into a SymLane and be integrated into a Street. Can the GN algorithm handle an intersection with only two streets of different widths? If so, we could even think about doing without SymLanes.

@polarkernel
Copy link
Collaborator

polarkernel commented Sep 10, 2024

I have rewritten createSymSideLanes(), so that it can handle multiple consecutive SymLanes or SideLanes. The case of changing directions of the streets is detected and for now, an Intersection is created instead of a SymLane.

EDIT: There was a bug in this code. The fix is recommitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants