-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloader doesn't "see" other images and videos from posts #3
Comments
Can confirm it stops after 5 items in any given post. Fansly changed something on their end. |
same |
Interesting, my downloads seem to work so far - did you notice the "
The authorization token may have just expired/reset after 30 days or whatever period. |
Still an issue with 0.7.6 (sorry). I don't see any "Follow the creator..." message, and I didn't with previous occurrences of the problem with Avnsx's version. I'm very definitely using the correct credentials. |
The fansly-downloader-ng/download/collections.py Lines 31 to 48 in 968775f
I hope this info was usefull :) PS. Even the fansly devs seem to missed the change, the "post info" on the preview no longer contains video durations for posts with over 5 elements. And for locked post is also wrong ^^ |
I'm trying to figure this out @ZincStoat but sorry, I don't fully get what you're saying. You say the screenshot has 11 images of which 5 were only downloaded. I see a screenshot of a messages download, where 23 are presumably scrapable. The screenshot only shows 11 lines of downloads, what happens after that? There should be 12 more (23 - 11). What is more, you say only 5 of 11 images were downloaded. On the screenshot I see 5 images and 6 videos (= 11) which should have downloaded according to the message. So I'm confused. Are you suggesting there are "Downloading ..." lines that effectively do not download anything? Are there less "Downloading ..." lines than "scrapable :" items? If only m3u8 videos made problems a recent code change might explain that. What is more, without having a concrete creator to analyze things are difficult. Sadly, official Fansly account has not many media but I tried to download it anyway - it say 8 pictures, which is true; downloads 5 because 2 of them are identical to another and 1 is locked behind a subscription I do not have. The difficult part is to tell how many double posts (identical media) a creator makes and the differentiation between preview/promo and regular media. There might also be different subscription tiers and paywalled items aside subscriptions. I'll try my last "legit" creator which doesn't do paywall tricks and I'm fully subscribed to and compare figures. But this looks more than 5 elements per timeline. I'm also missing 11 items but what the |
its not 5 elements per timeline. Its 5 elements per post If a post has more then 5 elements it only downloads the first 5 and then moves on to the next post. Its easier to see when you try downloading a post with more then 5 elements in single mode. |
Exactly this, simple as that. To observe anyway, I don't know how simple it will be to fix. |
Thanks for the clarification and sorry, I overlooked that single post downloading was the original topic, which is also a bit of a different beast in itself. I have a HAR file of a manual browsing session with my sample creator, maybe I can spot something where numbers don't add up. I also have to try single post mode because TBH I never use it personally so it's the least tested code path. Problem might also be that the creators I checked do usually post with 4 media items max. I do however, have some private things on my plate also so this may take some time. |
For what it's worth I don't think I've ever used single post mode, so it's not specific to that. |
As a remark - since the output of "items in posts and scrapable items" are 5 already in the informational header, this shows there might be something conceptually wrong in the usage of the reverse-engineered API, as if only media items you see while scrolling the whole timeline are seen/get downloaded by the scraper! So what the program got and downloaded is 5 and thus major part of processing and downloading itself is OK but obtaining timeline/post info seems flawed, or rather, incomplete. |
@Animalm4st3r I deleted the post with your helpful screenshot because you, I guess unintentionally, spilled the creator name ;-) Quoted text in my comment above, this is the fixed image. |
woops XD yes, i also tried it with older posts that had more then 5 elements, that i know worked previously and download in normal mode, they behave the sameway skip after 5 elements in an individual post, that also happens with the original from AVNSX, so i assume it happens because Fansly changed something on their end |
I figured it out (I hope), easier than I thought - but less easy to properly re-structure the code and avoid duplication. The (probably new) "timeline" structure has "posts", "account media" and "account media bundles". Avnsx just grabbed the "account media". Now each "post" has "attachments" which point to a specific "account media bundle" - which can contain more media! So as I suspected the "account media" probably only contains images you also see by scrolling through. Same is true for single posts, the deviance is even more obvious there (I could spot it instantly) - structure is the same as for "timelines". |
Ah, avoiding duplication, there's the trick. If you don't plan on having to hunt down everywhere you've fixed this when they inevitable make another update and break it again, a central "download everything for this one post" function would be the way to go. |
@KasumiDev thanks a lot for your efforts and kudos but I might have to decline, as I already have my own universal solution. |
No need, that's the power brought by refactoring into modules/single pieces - a new API call was needed, as @KasumiDev also discovered, but summarizing media infos is identical for all messages, timeline and post objects. |
No problem. I just wanted to share my findings and a possible solution. |
Running my customary 'Normal' mode download now and watching all the missing media get filled in. Thanks both. |
Please check development release (0.7.7) and give it a good try. If nothing else comes up I'll make a proper release of it later (maybe 0.8.0). This fixes messages, timelines and single post downloading. (I have no access to/idea about collections, though) Elegantly, the media IDs of https://github.com/prof79/fansly-downloader-ng/releases/tag/ondemand |
(PS @KasumiDev: really missed your post, likely some browser refresh issue as I just suspend my PC very often - helpful indeed! Though stepping through it myself helped grasping the dependencies) |
@ZincStoat Oh yes, please do - easier to track/handle. Those were some original design decisions by Avnsx, need to think that through/cross-check with single post differences. |
Thanks all, fixed by binary release 53bd7e1 / v0.7.10. |
Hi 👋🙂 I have a problem (and not only me as i see from posts on Fansly Downloader from Avnsx) I'm trying to download posts, but only thing it do is downloading only 5-6 images from post (when there are at least 50 images and 2-5 videos) I suppose it's like this because of recent Fansly "update". Preveously i could download entire post with images and videos (in collections too) now i can't do even this.
Hope the solution will be found
For example these 2 screenshots from the post with 13 images and 1 video:
The text was updated successfully, but these errors were encountered: