OPENCONFIG-gNMI - Port Speed is not returned for 100G interface and observing "Not supported speed: 100000!" log in telemetry.log during a gnmi_get

[sachin-brm]

Problem Description/Summary :

OPENCONFIG-gNMI - Port Speed is not returned for 100G interface and observing "Not supported speed: 100000!" log in telemetry.log during a gnmi_get

Expected Behavior :

Port Speed should get returned for 100G interface when performed gnmi_get operation on 100G interface like other speeds
should not observe "Not supported speed: 100000!" log in telemetry.log during a gnmi_get,as 100G is supported in SONIC platforms

Topology :

DUT

Steps to Repro :

1. Go to telemetry docker "docker exec -it telemetry bash"
2. Enable "tail -f /var/log/telemetry.log" in ssh session
3. Perform gNMI get operation on 100G interface as below ,observe that operation is successful but not displaying interface speed, and also in telemetry log observed that "Not supported speed: 100000!" log

root@sonic:/#gnmi_get -xpath /openconfig-interfaces:interfaces/interface[name=Ethernet92] -target_addr 127.0.0.1:8080 -insecure

getRequest:

prefix: <

path: <
elem: <
name: "openconfig-interfaces:interfaces"

elem: <
name: "interface"
key: <
key: "name"
value: "Ethernet92"

encoding: JSON_IETF

getResponse:

notification: <
timestamp: 1483973828416937111
prefix: <

update: <
path: <
elem: <
name: "openconfig-interfaces:interfaces"

elem: <
name: "interface"
key: <
key: "name"
value: "Ethernet92"

val: <
json_ietf_val: "{"openconfig-interfaces:interface":[{"config":{"description":"","mtu":9100,"name":"Ethernet92"},"name":"Ethernet92","state":{"admin-status":"UP","counters":{"in-broadcast-pkts":"7","in-discards":"1475","in-errors":"0","in-multicast-pkts":"1932","in-octets":"446497","in-pkts":"1939","in-unicast-pkts":"0","out-broadcast-pkts":"0","out-discards":"0","out-errors":"0","out-multicast-pkts":"1867","out-octets":"440221","out-pkts":"1867","out-unicast-pkts":"0"},"description":"","ifindex":23,"mtu":9100,"name":"Ethernet92","oper-status":"UP"},"subinterfaces":{"subinterface":[{"index":0,"openconfig-if-ip:ipv4":{"addresses":{"address":[\{"config":

{"ip":"192.168.1.1","prefix-length":24}
,"ip":"192.168.1.1","state":\{"ip":"192.168.1.1","prefix-length":24}}]}},"openconfig-if-ip:ipv6":{"addresses":{"address":[\{"config":

{"ip":"2001::1","prefix-length":64}
,"ip":"2001::1","state":\{"ip":"2001::1","prefix-length":64}}]}}}]}}]}"

4. telemetry log as below

Jan 9 14:57:08.417328 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.416945 53 translib.go:385] Received Get request for path = /openconfig-interfaces:interfaces/interface[name=Ethernet92]
Jan 9 14:57:08.417328 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.416966 53 app_interface.go:116] getAppModule called for path =/openconfig-interfaces:interfaces/interface[name=Ethernet92]
Jan 9 14:57:08.417328 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.416972 53 app_interface.go:123] found the entry in the map for path =/openconfig-interfaces:interfaces
Jan 9 14:57:08.417328 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.416978 53 app_interface.go:154] cast to appInterface worked&{ [] [] map[] map[] {0 {map[]}} map[] }
Jan 9 14:57:08.417531 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417159 53 intf_app.go:94] initialize:if:path =/openconfig-interfaces:interfaces/interface[name=Ethernet92]
Jan 9 14:57:08.417531 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417220 53 db.go:310] NewDB: Init indication not requested
Jan 9 14:57:08.417531 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417243 53 intf_app.go:227] translateGet:intf:path =&{/openconfig-interfaces:interfaces/interface[name=Ethernet92] /openconfig-interfaces:interfaces/interface{} map[name:Ethernet92]}
Jan 9 14:57:08.417531 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417258 53 intf_app.go:314] Received GET for path /openconfig-interfaces:interfaces/interface[name=Ethernet92]; template: /openconfig-interfaces:interfaces/interface{} vars=map[name:Ethernet92]
Jan 9 14:57:08.417592 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417287 53 intf_app.go:321] URI Path = /openconfig-interfaces:interfaces/interface
Jan 9 14:57:08.417592 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417293 53 intf_app.go:328] Interface Name = Ethernet92
Jan 9 14:57:08.417592 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417298 53 intf_app.go:747] Updating Interface info from APP-DB to Internal DS for Interface name : Ethernet92
Jan 9 14:57:08.417896 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417703 53 intf_app.go:756] Interface Info populated for ifName : Ethernet92
Jan 9 14:57:08.417896 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.417722 53 intf_app.go:550] /openconfig-interfaces:interfaces/interface - Not an interface state attribute
Jan 9 14:57:08.418387 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.418222 53 intf_app.go:706] OID : oid:0x1000000000009 received for Interface : Ethernet92
Jan 9 14:57:08.418540 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.418339 53 intf_app.go:644] /openconfig-interfaces:interfaces/interface - Not an interface state counter attribute
Jan 9 14:57:08.418540 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.418347 53 intf_app.go:780] Updating Interface IP Info from APP-DB to Internal DS for Interface Name : Ethernet92
Jan 9 14:57:08.419417 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.419245 53 intf_app.go:485] Found 14 INTF table keys
Jan 9 14:57:08.420211 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420052 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:08.420211 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420070 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:08.420211 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420079 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:08.420345 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420087 53 intf_app.go:868] Not supported speed: 100000!
Jan 9 14:57:08.420345 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420157 53 intf_app.go:899] IP address = 2001::1/64
Jan 9 14:57:08.420940 sonic INFO telemetry#supervisord: telemetry I0109 14:57:08.420828 53 intf_app.go:899] IP address = 192.168.1.1/24

5.this issue is not observed on other speeds like 25G

root@sonic:/#gnmi_get -xpath /openconfig-interfaces:interfaces/interface[name=Ethernet0] -target_addr 127.0.0.1:8080 -insecure

getRequest:

prefix: <

path: <
elem: <
name: "openconfig-interfaces:interfaces"

elem: <
name: "interface"
key: <
key: "name"
value: "Ethernet0"

encoding: JSON_IETF

getResponse:
notification: <
timestamp: 1483973864676020936
prefix: <

update: <
path: <
elem: <
name: "openconfig-interfaces:interfaces"

elem: <
name: "interface"
key: <
key: "name"
value: "Ethernet0"

val: <
json_ietf_val: "{"openconfig-interfaces:interface":[{"config":{"description":"","mtu":9100,"name":"Ethernet0"},"name":"Ethernet0","openconfig-if-ethernet:ethernet":{"config":{"port-speed":"openconfig-if-ethernet:SPEED_25GB"},"state":{"port-speed":"openconfig-if-ethernet:SPEED_25GB"}},"state":{"admin-status":"UP","counters":{"in-broadcast-pkts":"0","in-discards":"1610","in-errors":"0","in-multicast-pkts":"2055","in-octets":"489857","in-pkts":"2059","in-unicast-pkts":"4","out-broadcast-pkts":"6","out-discards":"0","out-errors":"0","out-multicast-pkts":"2061","out-octets":"493797","out-pkts":"2111","out-unicast-pkts":"44"},"description":"","ifindex":0,"mtu":9100,"name":"Ethernet0","oper-status":"UP"},"subinterfaces":{"subinterface":[{"index":0,"openconfig-if-ip:ipv4":{"addresses":{"address":[\{"config":

{"ip":"172.168.1.1","prefix-length":24}
,"ip":"172.168.1.1","state":\{"ip":"172.168.1.1","prefix-length":24}}]}},"openconfig-if-ip:ipv6":{"addresses":{"address":[\{"config":

{"ip":"1001::1","prefix-length":64}
,"ip":"1001::1","state":\{"ip":"1001::1","prefix-length":64}}]}}}]}}]}"

6.telemetry.log for 25G speed interface

Jan 9 14:57:44.676329 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676027 53 translib.go:385] Received Get request for path = /openconfig-interfaces:interfaces/interface[name=Ethernet0]
Jan 9 14:57:44.676329 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676045 53 app_interface.go:116] getAppModule called for path =/openconfig-interfaces:interfaces/interface[name=Ethernet0]
Jan 9 14:57:44.676329 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676050 53 app_interface.go:123] found the entry in the map for path =/openconfig-interfaces:interfaces
Jan 9 14:57:44.676329 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676055 53 app_interface.go:154] cast to appInterface worked&{ [] [] map[] map[] {0 {map[]}} map[] }
Jan 9 14:57:44.676551 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676200 53 intf_app.go:94] initialize:if:path =/openconfig-interfaces:interfaces/interface[name=Ethernet0]
Jan 9 14:57:44.676551 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676240 53 db.go:310] NewDB: Init indication not requested
Jan 9 14:57:44.676551 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676253 53 intf_app.go:227] translateGet:intf:path =&{/openconfig-interfaces:interfaces/interface[name=Ethernet0] /openconfig-interfaces:interfaces/interface{} map[name:Ethernet0]}
Jan 9 14:57:44.676551 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676263 53 intf_app.go:314] Received GET for path /openconfig-interfaces:interfaces/interface[name=Ethernet0]; template: /openconfig-interfaces:interfaces/interface{} vars=map[name:Ethernet0]
Jan 9 14:57:44.676551 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676282 53 intf_app.go:321] URI Path = /openconfig-interfaces:interfaces/interface
Jan 9 14:57:44.676575 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676287 53 intf_app.go:328] Interface Name = Ethernet0
Jan 9 14:57:44.676575 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676292 53 intf_app.go:747] Updating Interface info from APP-DB to Internal DS for Interface name : Ethernet0
Jan 9 14:57:44.676802 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676587 53 intf_app.go:756] Interface Info populated for ifName : Ethernet0
Jan 9 14:57:44.676802 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.676598 53 intf_app.go:550] /openconfig-interfaces:interfaces/interface - Not an interface state attribute
Jan 9 14:57:44.679820 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.679558 53 intf_app.go:706] OID : oid:0x1000000000012 received for Interface : Ethernet0
Jan 9 14:57:44.679975 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.679777 53 intf_app.go:644] /openconfig-interfaces:interfaces/interface - Not an interface state counter attribute
Jan 9 14:57:44.679975 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.679793 53 intf_app.go:780] Updating Interface IP Info from APP-DB to Internal DS for Interface Name : Ethernet0
Jan 9 14:57:44.680735 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.680598 53 intf_app.go:485] Found 14 INTF table keys
Jan 9 14:57:44.681223 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.681113 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:44.681223 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.681124 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:44.681223 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.681128 53 intf_app.go:881] Not a valid attribute!
Jan 9 14:57:44.681346 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.681163 53 intf_app.go:899] IP address = 1001::1/64
Jan 9 14:57:44.681765 sonic INFO telemetry#supervisord: telemetry I0109 14:57:44.681649 53 intf_app.go:899] IP address = 172.168.1.1/24

Reproducibility ( Ex:- 3 out of 3 attempts ) Please also update "Reproducible" field :

3

[jeff-yin]

@sachin-brm is this with the latest changes, including the fix #109 ?

@justinejose91 -- please try this out in the meantime. I suspect this may be fixed already, but would be good to confirm.

[justinejose91]

This issue is already fixed, can you try it with the latest build?
This pull-request needs to be taken in the build.
https://github.com/project-arlo/sonic-mgmt-framework/pull/109/files

[jeff-yin]

Closing for now; please re-open if this issue is still seen in the latest build.