Optimization for not building tree when the targetURI is not supported #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -933,6 +936,9 @@ func (app *IntfApp) processGetSpecificIntf(dbs [db.MaxDB]*db.DB, targetUriPath * | |||
| } | |||
|
|
|||
| ifInfo := intfObj.Interface[ifKey] | |||
| if *app.ygotTarget != ifInfo || *app.ygotTarget != ifInfo.Config || *app.ygotTarget != ifInfo.State { | |||
| return GetResponse{Payload: payload}, errors.New("Requested get type not supported!") | |||
| } | |||
There was a problem hiding this comment.
@justinejose91 This change might cause issue for following Get request targets:
- OpenconfigInterfaces_Interfaces_Interface_Aggregation_State
- OpenconfigInterfaces_Interfaces_Interface_Ethernet_SwitchedVlan_State
Can you please check and confirm?
There was a problem hiding this comment.
Yes, you are right. Could you add those cases in port-channel pull-request? Currently, we don't support container level get, like switched-vlan/state. What we support is, attribute level or top level. If we support it, yes, we need to add those statements.
There was a problem hiding this comment.
Probably, we need to add those cases in a map and handle it. That would be better handling.
jeff-yin
approved these changes
Oct 17, 2019
dell-engops
pushed a commit
that referenced
this pull request
Sep 19, 2022
…are-to-dell_sonic_4.x_share sync from broadcom_sonic_4.x_share to dell_sonic_4.x_share - 0907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.