Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization for not building tree when the targetURI is not supported #182

Merged
merged 8 commits into from
Oct 17, 2019
Merged

Optimization for not building tree when the targetURI is not supported #182

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e16d1b0
VLAN feature branch with changes for config and get support.
Oct 10, 2019
8137c62
Merge branch 'master' of https://github.com/project-arlo/sonic-mgmt-f…
Oct 10, 2019
5ba2ecb
Merge branch 'master' of https://github.com/project-arlo/sonic-mgmt-f…
Oct 10, 2019
44cebce
Resolved the conflicts and added the new changes wrt yang and tested,
Oct 10, 2019
bc80b51
Merge branch 'master' of https://github.com/project-arlo/sonic-mgmt-f…
Oct 14, 2019
23d066e
Addressed the review comments.
Oct 15, 2019
39308ee
Optimization for avoiding the processing if the URI is not what we su…
Oct 16, 2019
7828642
Merge branch 'master' of https://github.com/project-arlo/sonic-mgmt-f…
Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/translib/intf_cmn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ func (app *IntfApp) getSpecificIfVlanAttr(targetUriPath *string, ifKey *string,
if e != nil {
return true, e
}
if accessVlanName == nil {
return true, nil
}
vlanName := *accessVlanName
vlanIdStr := vlanName[len("Vlan"):len(vlanName)]
vlanId, err := strconv.Atoi(vlanIdStr)
Expand Down Expand Up @@ -933,6 +936,9 @@ func (app *IntfApp) processGetSpecificIntf(dbs [db.MaxDB]*db.DB, targetUriPath *
}

ifInfo := intfObj.Interface[ifKey]
if *app.ygotTarget != ifInfo || *app.ygotTarget != ifInfo.Config || *app.ygotTarget != ifInfo.State {
return GetResponse{Payload: payload}, errors.New("Requested get type not supported!")
}
Copy link
Collaborator

@Tejaswi-Goel Tejaswi-Goel Oct 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinejose91 This change might cause issue for following Get request targets:

  • OpenconfigInterfaces_Interfaces_Interface_Aggregation_State
  • OpenconfigInterfaces_Interfaces_Interface_Ethernet_SwitchedVlan_State

Can you please check and confirm?

Copy link
Author

@justinejose91 justinejose91 Oct 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Could you add those cases in port-channel pull-request? Currently, we don't support container level get, like switched-vlan/state. What we support is, attribute level or top level. If we support it, yes, we need to add those statements.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we need to add those cases in a map and handle it. That would be better handling.

app.processBuildTree(ifInfo, &ifKey)

if *app.ygotTarget == ifInfo {
Expand Down