Brcm poc1101 #248
Merged
Brcm poc1101 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia44eb293853f890edf25637e690dfa53273a397a
…to broadcom_sonic
1) Updated ACL CLIs not to use swagger generated client sdk. This can be used as an example for the new generic cli_client utility. 2) Fixed few issues with cli_client utility. Enhanced it to include url and error formatting APIs. 3) Renamed actioner script sonic-cli.py as sonic-cli-acl.py Change-Id: I92a8f88a8d91df0241bfa46eed45f399b0c27dc4
functions to enable/disable STP configs on Vlan additions/deletions and Vlan members addition/deletion. Change-Id: Iabea17b34c9292983faa79cd6ed4cdb2ad3712f6
NewPathInfo() API was not handling duplicate path parameters; first
parameter entry gets overwritten in PathInfo.Vars map. This is changed
to suffix "#N" to each duplicate parameter. N is the number of
occurrences of that parameter name from the left.
Example:
Path: /one[xx=1]/two[yy=2]/three[xx=3]/four[zz=4]/five[yy=5]/six[xx=6]
Vars: { "xx":"1", "yy":"2", "xx#2":"3", "zz":"4", "yy#2":"5", "xx#3":"6" }
Change-Id: Ic110bd7940b96f3c5cd00f5b0e764f60318b08ad
Introduced a new codegen.config file to control which yang models and OpenAPI specs should be used for swagger python client sdk codegen. Earlier client sdk was getting generated for all yangs, which takes lot of build time and space. Klish CLIs use only fraction of it. Also there were performance issues since each klish CLI handler loads full client code but uses only one function. Hence we are preferring a generic client src/CLI/actioner/cli_client.py for CLI use. Python client sdk will not be generated by default. Developer needs to whitelist the yang moduels for client codegen via PY_YANGAPI_CLIENTS variable. All Arlo yang modules are pre-populated for backward compatibility. Change-Id: Ice1e5c24ca1565575e077f73d3ecd81dfb913958
request made at /vlan/interface level. Fixed issue of creation of STP_VLAN entries when switchport is enabled on any interface even if STP is not enabled. Change-Id: I53776edf6f09964864c24e55d87abc8ff20021d3
generated Models The Autogenerated swagger models was having incorrect prefix in cases where yang was augmented through extesion yang and in some specific cases Change-Id: I2dcd8fcdf8b31d3888ea4167a4a3d804fe035093
Change-Id: I15a07c83434c8086c808e4b72fa1cad25b59e14a
These command still use swsssdk to gather info as management framework still has issues DevSanity - http://10.59.132.240:9009/projects/csg_sonic/sanity/logs/dev-sanity-th2-td3-02/sonic_dev_sanity_191024_1028_1794 Change-Id: I7611b13b2bbf2bc667644e7870c512beefbb8815
Change-Id: I4bc3f3f0e9c36735feaf2d318e31aae631172e8b
interface level. Added 2 new counters for RPVST+. Modified pt2pt_mac field to link_type. Added default value of "auto" for link_type. Change-Id: I76bd64c4351369aecf979fe6a113af83e61184ed
…hInfo" into broadcom_sonic
… info when request made at /vlan/interface level. Fixed issue of creation of STP_VLAN entries when switchport is enabled on any interface even if STP is not enabled." into broadcom_sonic
…el and interface level. Added 2 new counters for RPVST+. Modified pt2pt_mac field to link_type. Added default value of "auto" for link_type." into broadcom_sonic
… generated Models" into broadcom_sonic
addition of new field of bpdu_filter at global level. Change-Id: Ic46e3c4e3ee5ac73bad39dc78f4398792a59b751
KLISH Cli changes for supporting Arp & ND Suppress over Vxlan Tunnel. Below link has more details of this feature & ongoing discussions with community. sonic-net/SONiC#437 Change-Id: Iefe006ad7803f34bb56730e0779076d67d40ffae
…ix." into broadcom_sonic
…HLD" into broadcom_sonic
… into broadcom_sonic
… to addition of new field of bpdu_filter at global level." into broadcom_sonic
Change-Id: I69ebadbf3482eb5c4c221e435ef1d2e3f24cd5f5
Change-Id: Id28c561509eb4b1eda35389645fc22de19b18233
sonic-vlan in codegen.config to have client APIs generated for them. Fixed few issues with STP KLISH CLIs. Change-Id: I99c91951f8234ba6c19381de754ec052af89bfc1
KLISH CLI actioners for 'show vlan' and 'show po' are changed to use generic REST client instead of swagger client sdk. Enhanced CLI REST client to wrap all requests API exceptions into the response object. Change-Id: Ib11f5a979c35063e8839c5be20be1c4f71f805bc
…quest cache Change-Id: I6ea061024c4d2c7a911d99fbf14fbf3ff175e111
…d sonic-vlan in codegen.config to have client APIs generated for them. Fixed few issues with STP KLISH CLIs." into broadcom_sonic
Enhanced REST Server to handle escaped path parameter values - like "/ip=10.0.0.1%2f32". Value will be unescaped while converting to translib path, like "/ip[addr=10.0.0.1/32]" Change-Id: Ib907b4525f131584639bb8827a59634209e5beff
…from request cache" into broadcom_sonic
Added check for priority field to throw error if its value is not multiple of 4096. Removed sonic-vlan to avoid generation of python client APIs. Change-Id: Idb11b32200e2fcedbc62a7c49daada3b1ce70692
Change-Id: Iafca21ad399dbae826f4dd779d8c78bee32b953d
REST Server is enhanced to escape \ and ] chars with a \ for path key values while constructing translib path from REST URL path. PathInfo tool is update to decode such escaped chars. Change-Id: Iaeccd96f2b9e5acd5cebdd9001a19d11c220b5d6
STP_VLAN, STP_VLAN_INTF and STP_INTF entries on deletion of Vlans. Added Debug and Clear mock CLIs for UDLD feature. Change-Id: I74c9049004cc43fd3c7aea57c85484de369c14d9
when operID has a hash the conversion of hiphen to underscore was not taken care, this fixes this Change-Id: I4c20fda4f537e033815a9751175554a28d1fef65
Enabling swagger client generation for sonic-vxlan.yang Change-Id: Ib9cc4de8851158542a19a495193bc38af021377d
…p STP_VLAN, STP_VLAN_INTF and STP_INTF entries on deletion of Vlans. Added Debug and Clear mock CLIs for UDLD feature." into broadcom_sonic
… into broadcom_sonic
Enabling swagger client generation for sonic-sflow Change-Id: Ia4ef3494bf638651925a6a11b42d317c96b0e929
… into broadcom_sonic
a-barboza
requested review from
anand-kumar-subramanian,
bhavini-gada,
kwangsuk and
ranjinidn
anand-kumar-subramanian
approved these changes
Nov 5, 2019
Tejaswi-Goel
reviewed
Nov 5, 2019
| } | ||
|
|
||
| /* Adding member to LAG requires adding new entry in PORTCHANNEL_MEMBER Table */ | ||
| func (app *IntfApp) processUpdatePhyIntfLagAdd(d *db.DB) error { |
There was a problem hiding this comment.
@a-barboza After this change the function "processUpdatePhyIntfLagAdd" is repeated twice in this file, can you please correct it.
There was a problem hiding this comment.
@Tejaswi-Goel I see it. I'm wondering why it did not get flagged as a conflict. Are there any other changes added twice ?
There was a problem hiding this comment.
I did a manual diff between broadcom_sonic and brcm_poc1101, and those were the only diffs i noticed (processUpdatePhyIntfLagAdd() added twice). I'm still investigating why the git merge didn't flag it. In the interim, i raised a PR to fix it (#249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.