diff --git a/changelogs/unreleased/5575-yangyy93-minor.md b/changelogs/unreleased/5575-yangyy93-minor.md new file mode 100644 index 00000000000..fb452b0646c --- /dev/null +++ b/changelogs/unreleased/5575-yangyy93-minor.md @@ -0,0 +1,3 @@ +## Add outlier detection related configuration detection for services + +Add [outlier detection](https://www.envoyproxy.io/docs/envoy/v1.26.3/intro/arch_overview/upstream/outlier#arch-overview-outlier-detection) related configuration detection for services, including consecutiveServerErrors and localOriginal errors, and passive health checks can be performed on clusters. diff --git a/internal/dag/policy_test.go b/internal/dag/policy_test.go index 057b866615f..f733232220e 100644 --- a/internal/dag/policy_test.go +++ b/internal/dag/policy_test.go @@ -15,12 +15,12 @@ package dag import ( "errors" - "github.com/projectcontour/contour/internal/ref" "io" "testing" "time" contour_api_v1 "github.com/projectcontour/contour/apis/projectcontour/v1" + "github.com/projectcontour/contour/internal/ref" "github.com/projectcontour/contour/internal/timeout" "github.com/sirupsen/logrus" "github.com/stretchr/testify/assert" diff --git a/internal/envoy/v3/cluster.go b/internal/envoy/v3/cluster.go index c32c852968d..ea646439e2d 100644 --- a/internal/envoy/v3/cluster.go +++ b/internal/envoy/v3/cluster.go @@ -408,8 +408,6 @@ func outlierDetection(policy *dag.OutlierDetectionPolicy) *envoy_cluster_v3.Outl out.SplitExternalLocalOriginErrors = true if policy.ConsecutiveLocalOriginFailure > 0 { out.ConsecutiveLocalOriginFailure = protobuf.UInt32OrNil(policy.ConsecutiveLocalOriginFailure) - // Default to 100% if not specified - //out.EnforcingConsecutiveLocalOriginFailure = protobuf.UInt32OrNil(100) } else { // Default to 5 if not specified out.ConsecutiveLocalOriginFailure = protobuf.UInt32OrNil(5)