diff --git a/README.md b/README.md index 5a4e13cd..40238c9b 100644 --- a/README.md +++ b/README.md @@ -43,7 +43,7 @@ This is enforced for any case, whether a label matcher is specified in the origi ### Metadata endpoints -Similar to query endpoint, for metadata endpoints `/api/v1/series`, `/api/v1/labels`, `/api/v1/label/<name>/values` the proxy inject the specified label in the `match` selector. +Similar to query endpoint, for metadata endpoints `/api/v1/series`, `/api/v1/labels`, `/api/v1/label/<name>/values` the proxy injects the specified label in the `match` selector. NOTE: At the moment of creation `/api/v1/labels`, `/api/v1/label/<name>/values` does not support `match[]` so they are disabled by default. Use `-enable-label-apis` flag to enable those (see https://github.com/prometheus/prometheus/issues/6178 for tracking development). diff --git a/injectproxy/routes.go b/injectproxy/routes.go index 353e2d79..0c437e76 100644 --- a/injectproxy/routes.go +++ b/injectproxy/routes.go @@ -77,7 +77,7 @@ func NewRoutes(upstream *url.URL, label string, opts ...Option) *routes { if opt.enableLabelAPIs { mux.Handle("/api/v1/labels", enforceMethods(r.matcher, "GET")) // Full path is /api/v1/label/<label_name>/values but http mux does not support patterns. - // This is fine though as don't care about name for matcher injector. + // This is fine though as we don't care about name for matcher injector. mux.Handle("/api/v1/label/", enforceMethods(r.matcher, "GET")) }