Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name of Win32_PerfRawData_PerfDisk_LogicalDisk metrics #3

Closed
martinlindhe opened this issue Aug 27, 2016 · 6 comments
Closed

Comments

@martinlindhe
Copy link
Collaborator

Currently named "perf"

Suggested names:

  • disk
  • io

Please add a vote or another suggestion, We'll rename it in a few days.

@martinlindhe
Copy link
Collaborator Author

@carlpett

@carlpett
Copy link
Collaborator

My vote would be logical_disk, despite the length :) If we will expose the PhysicalDisk family some time (which I think would be useful) , it will need to be possible to distinguish them.

@martinlindhe
Copy link
Collaborator Author

Makes sense. I have no objections :-)

@martinlindhe
Copy link
Collaborator Author

martinlindhe commented Aug 27, 2016

Do you mind doing the rename, if you are already knee-deep in the code? If not, I'll do it on monday or so. Also the perf.go should be renamed to logical_disk.go, and maybe refactor the subsystem name into a const.

@carlpett
Copy link
Collaborator

Sure! Good point about the const as well.

@martinlindhe
Copy link
Collaborator Author

(hopefully resolved in #5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants