Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Truncate messages with fewer characters. #3050

Closed
joeblubaugh opened this issue Aug 30, 2022 · 5 comments
Closed

Feature Request: Truncate messages with fewer characters. #3050

joeblubaugh opened this issue Aug 30, 2022 · 5 comments
Labels
help wanted kind/enhancement

Comments

@joeblubaugh
Copy link
Contributor

Alertmanager truncates messages using three full stops (U+002E): .... We could instead truncate with a single ellipsis (U+2026) …, freeing up two additional characters for the message contents.

alertmanager/notify/util.go

Line 93 in c732372

return string(r[:n-3]) + "...", true

@joeblubaugh
Copy link
Contributor Author

(I'm happy to submit the PR)

@yanksyoon
Copy link
Contributor

yanksyoon commented Sep 1, 2022 •
edited
Loading

Hi @joeblubaugh, I'm trying to familiarize with the codebase, would you mind if I work on it if this request gets approved? :) Also fine if you've got it going!

@joeblubaugh
Copy link
Contributor Author

Sounds great!

@simonpasquier
Copy link
Member

sounds good to me

@yanksyoon yanksyoon mentioned this issue Sep 11, 2022
Merged
@simonpasquier
Copy link
Member

Closed by #3072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeblubaugh @simonpasquier @yanksyoon