From 88f4fbb07866ae2a1bf4f570fb45e6d5dcc8473d Mon Sep 17 00:00:00 2001 From: Cristian Greco Date: Wed, 10 Jul 2024 11:56:36 +0200 Subject: [PATCH] Fix fetching tmpTables vs tmpDiskTables from performance_schema The `perf_schema.eventsstatements` collector was incorrectly exposing "tmp_tables" as "tmp_disk_tables" and vice versa, due to query result being scanned in incorrect order. Closes #849 --- collector/perf_schema_events_statements.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/collector/perf_schema_events_statements.go b/collector/perf_schema_events_statements.go index 568bde7c8..59e8b28a9 100644 --- a/collector/perf_schema_events_statements.go +++ b/collector/perf_schema_events_statements.go @@ -192,7 +192,7 @@ func (ScrapePerfEventsStatements) Scrape(ctx context.Context, db *sql.DB, ch cha ) for perfSchemaEventsStatementsRows.Next() { if err := perfSchemaEventsStatementsRows.Scan( - &schemaName, &digest, &digestText, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpTables, &tmpDiskTables, &sortMergePasses, &sortRows, &noIndexUsed, + &schemaName, &digest, &digestText, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpDiskTables, &tmpTables, &sortMergePasses, &sortRows, &noIndexUsed, ); err != nil { return err }