Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: include-on-hold doesn't appear to be working #20

Closed
1 task done
rogerswingle opened this issue Jun 12, 2024 · 0 comments · Fixed by #21
Closed
1 task done

Bug: include-on-hold doesn't appear to be working #20

rogerswingle opened this issue Jun 12, 2024 · 0 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@rogerswingle
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Orb version

3.0.0

Current behavior

regardless of what value is set for include-on-hold, global_block only checks running or created workflows. Running with debug true always prints DEBUG: filtering on statuses: ["running","created"]

Minimum reproduction config

workflow-queue/queue:
debug: true
time: '30'
include-on-hold: false
confidence: "2"

Other

I think the issue may be cause by an extra space between the " and the << in

CONFIG_INCLUDE_ON_HOLD: " << parameters.include-on-hold >>"

@rogerswingle rogerswingle added the bug Something isn't working label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant