GitLab pull request formatter

[ivanovaleksey]

Hi @mmozuras,

thank you for the awesome gem!

I use it with GitLab instance.
I noticed that only commit formatter exists for GitLab. But GitLab API contains endpoints to work with comments on pull requests (merge requests as they call them).

Is it possible to enable pull request commenting for GitLab (maybe there are some restrictions I don't know about) ?
If it is I would happily start to working on it.

[ivanovaleksey]

Seems like I understand the problem now.
Merge request API allows to create a note for the entire merge request. We can't specify particular line of code.
And comment for commit API allows to do per-line commenting.

😞

[mikgry]

Hi, the Merge request API should have per-line commenting soon, it is already implemented https://gitlab.com/gitlab-org/gitlab-ce/issues/20901
It will be released in 9.2 version at May 21.

[ivanovaleksey]

@mikes01 cool, thank you!
Then I will continue my work on PR after API updates.

[ivanovaleksey]

Looks like implementing this feature will also close #106

[ivanovaleksey]

It seems like the GitLab issue was moved to 9.3 milestone which has due date on June, 21.

[mmozuras]

@ivanovaleksey 👍

Maybe you know the reason? Not stable enough?

[ivanovaleksey]

@mmozuras to be honest I didn't read all the discussions because the are huge enough.
As I can see 9.2 (initial milestone for the issue) still has very much to do. And it should be closed 3 days ago, on May 21 😕

UPDATE
I got an email that 9.2 has been released. ☺️

[ivanovaleksey]

And it is moved to 9.4 😞

[siebertm]

This API seems to be implemented in 10.8 release :-D https://docs.gitlab.com/ce/api/discussions.html

[mmozuras]

@siebertm great news (finally 😀)!

If anyone wants to take the implementation, write about it here.

[Strnadj]

PR #308 😄

[vkotovv]

Looks like it can be closed now, resolved by PR #351

[ivanovaleksey]

@vkotovv thanks for pointing this out. Currently I am not using Pronto, so I can't actually test behaviour.
I will close the issue. If there would be any problems write a comment to reopen.