Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting running projections will not restart from event 0 #168

Closed
basz opened this issue Aug 26, 2018 · 2 comments
Closed

deleting running projections will not restart from event 0 #168

basz opened this issue Aug 26, 2018 · 2 comments
Labels

Comments

@basz
Copy link
Member

basz commented Aug 26, 2018

When I have a projection running that is instructed to delete with deletion projections are not removed until all events have been processed.

I would expect it would finish projecting events within the batch size configuration option to then delete and restart.

discovered this via snapshots which are also read model projections.

Looking at the code this seems to be true for all status changes (stop, delete and reset) as the method handleStreamWithSingleHandler does not check for status at all.

I've experimented a bit to fix this inside the handleStreamWithSingleHandler method, but it's not as simple as calling this->reset(). One possible solution seems to be to simply stop when status is not running.

@prolic
Copy link
Member

prolic commented Sep 6, 2018

@basz can this be closed now?

@prolic prolic added the bug label Sep 6, 2018
@basz
Copy link
Member Author

basz commented Sep 6, 2018

Closing per #170

@basz basz closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants