Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker Interfaces for indexing strategies #4

Closed
codeliner opened this issue Nov 6, 2016 · 1 comment
Closed

Marker Interfaces for indexing strategies #4

codeliner opened this issue Nov 6, 2016 · 1 comment

Comments

@codeliner
Copy link
Member

While trying the pdo adapter I ran into an issue due to a wrong indexing strategy used by the adapter.
I wanted to use pdo_pgsql but did not configure the indexing strategy so the factory used the MySql indexing strategy as a default.

I got a syntax error:

Fatal error: Uncaught Prooph\EventStore\Adapter\Exception\RuntimeException: Error during createSchemaFor: 42601; 7; ERROR:  syntax error at or near "`"
LINE 1: CREATE TABLE `_878c0b7e51ecaab95c511fc816ad2a70c9418208` (
                     ^ in /var/www/html/vendor/prooph/event-store-pdo-adapter/src/PDOEventStoreAdapter.php:354

We should either remove the default to force the user to set a strategy or mark the strategies with vendor specific interfaces so that the PdoAdapter can check if an indexing strategy is used that can work together with the used database vendor.

@prolic prolic closed this as completed Nov 8, 2016
@prolic
Copy link
Member

prolic commented Nov 8, 2016

done by eb2094a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants