Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Death Loop with load reverse lacking $count #64

Closed
oqq opened this issue Mar 9, 2017 · 2 comments
Closed

[DRAFT] Death Loop with load reverse lacking $count #64

oqq opened this issue Mar 9, 2017 · 2 comments

Comments

@oqq
Copy link
Member

oqq commented Mar 9, 2017

Needs more investigation by me and a test case.

Would end in an endless loop:

$events = $this->eventStore->loadReverse(
    new StreamName($streamName),
    PHP_INT_MAX,
    null, # <----
    $metadataMatcher
);

Works fine:

$events = $this->eventStore->loadReverse(
    new StreamName($streamName),
    PHP_INT_MAX,
    1000, # <----
    $metadataMatcher
);

1.0.0-beta3

@prolic
Copy link
Member

prolic commented Mar 10, 2017

please check with latest develop branch

@oqq
Copy link
Member Author

oqq commented Mar 10, 2017

cannot reconstruct with current dev branch, so could be closed.

@oqq oqq closed this as completed Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants