fix for broken alter-table statements when default column values cont… #1566
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When a column
defaultValue
contains a semicolon (;
) the generated alter-table statement is broken.the reason for that can be found in file
/src/Propel/Generator/Platform/DefaultPlatform.php
line818ff
the already generated sql string consists of multiple
alter table
statements and shall be split into singlealter table
statements to merge. If the generated statementcontains multiple semicolons so the splitting goes wrong.
The solution
propel already contains a sql statement parser that can be used as a drop-in replacement here.