Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses limited to 1024 characters #4

Open
faultyserver opened this issue Mar 15, 2017 · 0 comments
Open

Responses limited to 1024 characters #4

faultyserver opened this issue Mar 15, 2017 · 0 comments
Labels

Comments

@faultyserver
Copy link
Member

mpackCPP defines the data buffer for a node to statically be 1024 characters. This means that responses longer than 1024 characters will appear truncated and have an invalid representation.

The easiest (and likely viable) solution would be to expand the buffer to 4096 characters, but the real solution is to replace the implementation with std::string. Both of these require modification to mpackCPP itself, so the std::string solution is probably better to go with now rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant