Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 code generation? #22

Open
afk11 opened this issue Mar 25, 2018 · 2 comments
Open

PHP7 code generation? #22

afk11 opened this issue Mar 25, 2018 · 2 comments

Comments

@afk11
Copy link

afk11 commented Mar 25, 2018

Hi there

A massive thank you for your work on the library to date - I came from using the DrSlump lib from a few years back which isn't maintained much, so it's been a great help to have a modern alternative!

I wanted to see what you thought about generating php7 code - is it in the near future or would you accept a pull request for this?

@FabioBatSilva
Copy link
Member

Hi..

That is not on my radar for the near future.
But of course I would review/accept a PR.

Also notice that google added support php..
Not sure how stable it is at this point and how well it support php7 but it might be another option if using a extension is ok https://github.com/google/protobuf/tree/master/php

@afk11
Copy link
Author

afk11 commented Mar 26, 2018

I have considered that library, but some of the projects I maintain are v2 format which doesn't seem to be supported by google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants