Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel] Stop using rules_jvm_external default maven repository name #17117

Closed
joca-bt opened this issue Jun 12, 2024 · 1 comment
Closed

[Bazel] Stop using rules_jvm_external default maven repository name #17117

joca-bt opened this issue Jun 12, 2024 · 1 comment
Labels
untriaged auto added to all issues by default when created.

Comments

@joca-bt
Copy link

joca-bt commented Jun 12, 2024

The protobuf Bazel module depends on rules_jvm_external and it's including the artifacts it needs under the default maven repository name (@maven, https://github.com/protocolbuffers/protobuf/blob/main/WORKSPACE#L65). This can create some issues for rules_jvm_external users, as described in bazel-contrib/rules_jvm_external#1168.

Is it necessary for these artifacts to be under the default maven repository name? Otherwise, could we use a different name for the maven repository so it won't conflict with other modules or users' projects (https://github.com/bazelbuild/rules_jvm_external?tab=readme-ov-file#multiple-maven_installjson-files)? This should also lead to a better isolation of this module.

For example:

maven_install(
    name = "maven_protobuf",
    ...
)
@joca-bt
Copy link
Author

joca-bt commented Jan 19, 2025

Addressed in #19477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged auto added to all issues by default when created.
Projects
None yet
Development

No branches or pull requests

1 participant