Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand benchmarks for Java #842

Closed
nmittler opened this issue Sep 30, 2015 · 4 comments
Closed

Expand benchmarks for Java #842

nmittler opened this issue Sep 30, 2015 · 4 comments

Comments

@nmittler
Copy link

From grpc/grpc-java#1054:

Implement some basic protobuf benchmarks independent of GRPC
(scrape the web or extract Googles) as a framework for experimenting
with optimizations

The gRPC team has a few ideas for optimizing protobuf marshalling but we need to expand the benchmark suite before that work can begin.

cc/ @louiscryan @ejona86 @xfxyjwf

@nmittler
Copy link
Author

FYI, I'd be happy to do the work here.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 30, 2015

The benchmarks for proto Java are not opensourced. I suggest we track this bug internally, add new benchmarks to our internal code base and then get part of these benchmarks opensourced if needed.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 30, 2015

Also, for significant protobuf changes like this (the planned performance optimizations) we should do it internally first to make sure it does not impact google3 users negatively.

@nmittler
Copy link
Author

@xfxyjwf sgtm ... I'll close this for now and continue internally. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants