Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(regression): Relation attrIndex keys are in lower case but lookup is not #86

Closed
trakhimenok opened this issue Aug 21, 2023 · 1 comment · Fixed by #87 or #88
Closed

Bug(regression): Relation attrIndex keys are in lower case but lookup is not #86

trakhimenok opened this issue Aug 21, 2023 · 1 comment · Fixed by #87 or #88

Comments

@trakhimenok
Copy link
Contributor

Started to get this error after upgrading from v0.0.1 to v0.1.0:

"attribute not defined"

I have this table definition:

CREATE TABLE DalgoE2E_E2ETest1 (ID1 VARCHAR(10) PRIMARY KEY, StringProp TEXT, IntegerProp INT);

And am trying to query data as:

SELECT StringProp, IntegerProp FROM DalgoE2E_E2ETest1

Column names comes to the func (r *Relation) Attribute(name string) (int, Attribute, error) in original CamelCase but are in lower case in Relation.attrIndex.

I believe this line should bring the name to lowercase like:

index, ok := r.attrIndex[strings.ToLower(name)]
@trakhimenok trakhimenok changed the title Bug(regression): Relation attrIndex keys are in lower case but looks is not Bug(regression): Relation attrIndex keys are in lower case but lookup is not Aug 21, 2023
@proullon
Copy link
Owner

Issue is still present, cf failing test in #fix/86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants