report of DetectSecrets line number is wrong

[kagahd]

Steps to Reproduce

Run a check which uses DetectSecrets e.g. ecs_task_definitions_no_environment_secrets on a resource with potential secrets. The check will report the line number where the potential secret was found.
Prowler's ecs_task_definitions_no_environment_secrets metadata states:

If a secret is detected, the line number shown in the finding matches with the environment variable Name attribute starting to count at the environment key from the ECS Task Definition in JSON format.

Given the following example the key environment of a AWS ECS task definition in json format which is shown in AWS console as follows:

"environment": [
  {
      "name": "FIRST_PARAM",
      "value": "first value"
  },
  {
      "name": "SECOND_PARAM",
      "value": "second value"
  },
  {
      "name": "POTENTIAL_SECRET",
      "value": "potential secret"
  }
]

If the third entry of the environment key of the task definition contains a potential secret, the check would indicate line number four. Why is it so? Because the json that prowler is passing to DetectSecrets is transformed as follows:

{
  "FIRST_PARAM": "first value",
  "SECOND_PARAM": "second value",
  "POTENTIAL_SECRET": "potential secret",
}

Obviously, DetectSecrets counts the opening curly bracket from the json expression as line number one.

Expected behavior

I'd expect to read the correct line number in prowler's report.

Actual Result with Screenshots or Logs

doesn't matter

How did you install Prowler?

Cloning the repository from github.com (git clone)

Environment Resource

Docker container locally

OS used

MacOS

Prowler version

5.0.5

Pip version

doesn't matter

Context

No response

[pedrooot]

Hey @kagahd thanks for the heads up!
We'll review the detect-secrets behaviour and we'll ping you with the solution when we find it.