Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to support more actions for rust callbacks(as in cpp sdk)? #105

Closed
dandlake opened this issue May 6, 2021 · 2 comments

Comments

@dandlake
Copy link

dandlake commented May 6, 2021

In rust sdk, those header/body callbacks can only return "Pause" or "Continue" action:

pub enum Action {
    Continue = 0,
    Pause = 1,
}

In cpp sdk, there are more:

enum class FilterHeadersStatus : int32_t {
  Continue = 0,
  StopIteration = 1,
  ContinueAndEndStream = 2,
  StopAllIterationAndBuffer = 3,
  StopAllIterationAndWatermark = 4,
};

enum class FilterDataStatus : int32_t {
  Continue = 0,
  StopIterationAndBuffer = 1,
  StopIterationAndWatermark = 2,
  StopIterationNoBuffer = 3
};

Any plan to bring those additional actions to rust sdk? We hope to have better control over the buffering behavior in our rust filter.

@dandlake dandlake changed the title Any plan to support more actions for rust callbacks(as in cpp sdk) Is there any plan to support more actions for rust callbacks(as in cpp sdk)? May 6, 2021
@aweis89
Copy link

aweis89 commented May 26, 2021

This is intentional, see: #39

@dandlake
Copy link
Author

dandlake commented Jun 8, 2021

Thanks, @aweis89! I see the background now.

@dandlake dandlake closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants