[BFW-6065] [BUG] /api/v1/job GET response contains invalid JSON

[ysmilda]

Printer model

Mini+

Firmware version

>= v5.0.0-alpha3

Upgrades and modifications

No response

Printing from...

PrusaLink

Describe the bug

When a job is present without stat the returned JSON response for a GET request to /api/v1/job is invalid. It contains a comma at the end of the object which should only be there if the message has stat.

Prusa-Firmware-Buddy/lib/WUI/link_content/basic_gets.cpp

Lines 434 to 438 in f5a498a

	JSON_FIELD_STR("path", sfn_path) JSON_COMMA;
	if (has_stat) {
	JSON_FIELD_INT_G(has_stat, "size", st.st_size) JSON_COMMA;
	JSON_FIELD_INT_G(has_stat, "m_timestamp", st.st_mtime);
	}

Moving the JSON_COMMA macro from the end of line 434 to the start of line 436 should fix the message.

How to reproduce

No response

Expected behavior

No response

Files

No response

[danopernis]

Hello, thanks for the bug report and thanks for the pull request. This is indeed a bug, I am opening internal ticket to track it.

[danopernis]

Thanks for the contribution, this is scheduled for next 6.2.0 version

[danopernis]

@ysmilda I pushed this to the 6.2.0-alpha2 which was just released, in case you want to try it before final 6.2.0 is released.