Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black is compromising on trailing comma in one line #1472

Closed
uriva opened this issue Jun 1, 2020 · 4 comments
Closed

Black is compromising on trailing comma in one line #1472

uriva opened this issue Jun 1, 2020 · 4 comments
Labels
T: style What do we want Blackened code to look like?

Comments

@uriva
Copy link

uriva commented Jun 1, 2020

Black allows this:

foo(bar,)

and also this

foo(bar)

Leaving freedom for arguing and inconsistency. I think best decide to go with either one and make the formatter fix it.
@uriva uriva added the T: style What do we want Blackened code to look like? label Jun 1, 2020
@uriva
Copy link
Author

uriva commented Jun 1, 2020 •
edited
Loading

Duplicated with #725 (somewhat).

@traviswaelbro
Copy link

If this is a duplicate of #725, then can this issue be closed?

@traviswaelbro
Copy link

Actually, it looks like this and #725 are both duplicates which are being addressed in #1288.

@uriva
Copy link
Author

uriva commented Jun 7, 2020

sgtm

@uriva uriva closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: style What do we want Blackened code to look like?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uriva @traviswaelbro