Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up items for the Jupyter PR #2413

Closed
ichard26 opened this issue Aug 6, 2021 · 2 comments · Fixed by #2416
Closed

Follow-up items for the Jupyter PR #2413

ichard26 opened this issue Aug 6, 2021 · 2 comments · Fixed by #2416
Labels
C: jupyter Jupyter Notebooks, any color you like C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases T: documentation Improvements to the docs (e.g. new topic, correction, etc)

Comments

@ichard26
Copy link
Collaborator

ichard26 commented Aug 6, 2021

PR #2357 was recently merged 🎉 For the sake of getting it merged somewhat quickly and to not tire everyone, we left a few TO-DO items for later. This issue attempts to list 'em so we don't forget :)

  • Add documentation about the newly exported black-jupyter pre-commit hook
  • Look into whether we should add the Jupyter deps to Pipfile or just document the quirk (tox is unaffected)

I probably already forget a few tho, so feel free to edit / comment with more.
@ichard26 ichard26 added T: documentation Improvements to the docs (e.g. new topic, correction, etc) C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Aug 6, 2021
@MarcoGorelli MarcoGorelli mentioned this issue Aug 7, 2021
Merged
@MarcoGorelli
Copy link
Contributor

Hey @ichard26

I'm happy to help out with this - could you please clarify the second item? I don't understand what

just document the quirk (tox is unaffected)

means

@MarcoGorelli MarcoGorelli mentioned this issue Aug 10, 2021
Merged
@ichard26
Copy link
Collaborator Author

Oh actually @MarcoGorelli, I totally forgot that I was doing this, but it would be 100% awesome if you could comment here: #2238 ... with any feedback and noteworthy things about your experience contributing here. Once again, thanks so much for all of the great development!

@JelleZijlstra JelleZijlstra added the C: jupyter Jupyter Notebooks, any color you like label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: jupyter Jupyter Notebooks, any color you like C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases T: documentation Improvements to the docs (e.g. new topic, correction, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document jupyter hook MarcoGorelli/black
3 participants
@JelleZijlstra @MarcoGorelli @ichard26