-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP upgrade to blacklight 8 #1295
base: main
Are you sure you want to change the base?
Conversation
…rails 7 upgrade, this is just a bit of clean up.
…aced render_search_bar. Without the partial, advanced search and start over link were not rendering. I added them back into the search bar and added a test so if it disappears again we will know
…r_document_main_content_partial, and document_show_html_title
…ctionality are now in core blacklight so upgrading the gem meant moving a lot of our gem overrides to core bl overrides. While this is functional as is, many of the methods in advanced_search_facets_as_select will be depreciated in BL 8 so that it still a work in progress.
…ress depreciations
… ActionComponent instead. The url method got messed up with our ris and bulk_ris actions so I did a quick fix. Ideally, we will go back and refine this a bit
… document RIS needed to be adjusted accordingly as well.
… with the BL 8 upgrade and Ruth gave the ok to just remove them
…is modifies how session_tracking_params is called as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far this looks good. There's a lot here so I'm kind of skimming over a lot of things, but there was only one thing that stood out to me.
@@ -1,4 +1,5 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed since we're on rails 7 now.
Fixes #1289