Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wings: Script does not detect openvz and lxc at the same time #200

Closed
sinjs opened this issue Jun 23, 2021 · 4 comments · Fixed by #207
Closed

wings: Script does not detect openvz and lxc at the same time #200

sinjs opened this issue Jun 23, 2021 · 4 comments · Fixed by #207

Comments

@sinjs
Copy link
Contributor

sinjs commented Jun 23, 2021

Describe the bug
Docker can't run on openvz and lxc. The script detects if the user is running openvz or lxc but not if they are using them at the same time:

$ virt-what
openvz
lxc

To Reproduce
Get a machine using lxc and openvz and try to install wings.

Expected behaviour
The script should complain about the virtualization type

Additional context
In code:
https://github.com/vilhelmprytz/pterodactyl-installer/blob/8febae1a48d60ecc2fd68c5eda4657b6eb9e8e42/install-wings.sh#L240-L244
Discord:
https://discord.com/channels/682342331206074373/682356044898500634/857019203088678923

@Linux123123
Copy link
Member

The fix might be as simple as checking for *openvz* | *lxc*), instead of checking for openvz | lxc). But not gonna lie it's an oddball case.

@vilhelmprytz
Copy link
Member

Do you run LXC containers inside OpenVZ or the other way around?

@sinjs
Copy link
Contributor Author

sinjs commented Jul 3, 2021 via email

@sinjs
Copy link
Contributor Author

sinjs commented Jul 11, 2021

Update: someone has got another type of LXC

$ virt-what
virtual machine lxc

https://discord.com/channels/682342331206074373/718551748431577139/863723503950102528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants