Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine "last recommend" and "cooldown" timers #60

Open
wens opened this issue May 28, 2019 · 0 comments
Open

Combine "last recommend" and "cooldown" timers #60

wens opened this issue May 28, 2019 · 0 comments

Comments

@wens
Copy link
Contributor

wens commented May 28, 2019

Currently there are two systems in place to prevent abuse:

  1. Opt-in per-board limitations on push/recommend intervals
  2. System-wide "cooldown" mechanic for board opt-in and mandatory limitations on accounts with rejected articles.

The timer for the first system is non-persistent, meaning it is reset when the user logs off.
The timer for the second system is persistent in shared memory, but the rules for it are slightly opaque, and it only has 15 second resolution.

It may be a good trade-off to use the persistent timer of the second system for the first one as well. If the resolution is unacceptable, then move out the rejected-article counter to restore it to per-second resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant