Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor only the resolve step in the sudoku bench #285

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented Nov 21, 2024

This PR modifies the sudoku bench to only monitor the resolve step.

@x-hgg-x x-hgg-x changed the title Keep only the resolve step for the sudoku bench Monitor only the resolve step in the sudoku bench Nov 21, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #285 will improve performances by ×4

Comparing x-hgg-x:sudoku-bench (c319a56) with dev (4c6cdde)

Summary

⚡ 2 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark dev x-hgg-x:sudoku-bench Change
sudoku-easy 15.3 ms 3.8 ms ×4
sudoku-hard 15.5 ms 3.9 ms ×4

Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, @konstin up to you.

@konstin
Copy link
Member

konstin commented Nov 26, 2024

Some more general thoughts: For real benchmarks, we should track both the setup time and the runtime, since the user has to pay both. But since the sudoku is more a gadget (we can take it out of codspeed now that we have better benchmarks), it's fine to only track the resolve step here.

@konstin konstin added this pull request to the merge queue Nov 26, 2024
Merged via the queue into pubgrub-rs:dev with commit 3741e3b Nov 26, 2024
6 checks passed
@x-hgg-x x-hgg-x deleted the sudoku-bench branch November 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants