You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We upgraded from 2.0.2 to 3.0 and noticed a breaking change, that is parameters defaults to nil now. Can we revert this behavior or was this done for a reason?
Using public_activity 2.0.2
irb(main):001> PublicActivity::Activity.new.parameters
=> {}
Using public_activity 3.0.0 (was 2.0.2)
irb(main):001> PublicActivity::Activity.new.parameters
=> nil
The text was updated successfully, but these errors were encountered:
2called-chaos
changed the title
v3 has breaking change
v3 has breaking change (parameters defaults to nil)
Feb 2, 2024
On further investigation this change stems from 1575d8c and the fact that Rails - when using serialize :col, Hash - used to check for the second argument to
be literal ::JSON (and then use a Rails wrapper)
respond to both load and dump (which Hash does not)
fallback to use Coders::YAMLColumn (instead of just YAML)
The YAMLColumn coder guards against nil values with return object_class.new if object_class != Object && yaml.nil? (recently this has moved to Coders::ColumnSerializer in Rails)
We upgraded from 2.0.2 to 3.0 and noticed a breaking change, that is
parameters
defaults to nil now. Can we revert this behavior or was this done for a reason?Using public_activity 2.0.2
irb(main):001> PublicActivity::Activity.new.parameters
=> {}
Using public_activity 3.0.0 (was 2.0.2)
irb(main):001> PublicActivity::Activity.new.parameters
=> nil
The text was updated successfully, but these errors were encountered: