Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logical NOT operator where unnecessary and modify code #1251

Closed
Josephsanya opened this issue Oct 27, 2022 · 1 comment · Fixed by #1265
Closed

Remove logical NOT operator where unnecessary and modify code #1251

Josephsanya opened this issue Oct 27, 2022 · 1 comment · Fixed by #1265

Comments

@Josephsanya
Copy link
Contributor

Hi, this is an issue I found in the code.
The codebase is looking very old ES5 way and needs more of updating to improve the site.

I think this will help improve the map knitter site.

This issue is to fix the logical NOT operator, where it was inverted, fix double and single quotes, in the file src/edit/actions/ExportAction.js then other minor fixes in the file which may seem minor, but adds up to the improvement of the site.

I hope this little fixes help the map knitter site. THANKS.

@welcome
Copy link

welcome bot commented Oct 27, 2022

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant