Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input component for adding existing pubs as relations in forms #791

Open
gabestein opened this issue Nov 19, 2024 · 4 comments · May be fixed by #910
Open

Input component for adding existing pubs as relations in forms #791

gabestein opened this issue Nov 19, 2024 · 4 comments · May be fixed by #910
Assignees
Labels

Comments

@gabestein
Copy link
Member

gabestein commented Nov 19, 2024

Motivation

So users can add and remove references to their pubs via the field in a form

Requirements

  • Users can search by pub title through pre-existing pubs and add them as a relation
  • Users can delete added relationships

Acceptance Criteria

  • Does not implement creating pubs, either via form or upload
  • Does not implement editing related pubs (that would only be for created pubs)
  • For editing existing pubs via a form, adding/removing new relations should be auto-saved using existing mechanisms.
  • For editing a new pub via a /fill form, adding/removing new relations should be saved at point of clicking save, using createPubResursiveNew
  • Relies on Ability to add relation fields to forms #790 for input type settings

Out Of Scope

  • Editing value of relation field
  • Ordering relations

Mockups
https://www.figma.com/design/SqOTMElJn7fuPljfQL1gIY/PubPub-Platform?node-id=1711-73388&m=dev

@gabestein gabestein converted this from a draft issue Nov 19, 2024
@ktyjscott ktyjscott self-assigned this Dec 16, 2024
@gabestein gabestein changed the title Reference Field Form Input UI Ability to add existing pubs as relations in forms Jan 12, 2025
@gabestein
Copy link
Member Author

@ktyjscott -- I think you were working on mocking up the second requirement, editing the value field, but haven't yet seen that in mocks. Let us know if that's ready yet.

@gabestein
Copy link
Member Author

Users can re-order the pubs they’ve added as relationships

I recall we had had a discussion that this would be accomplished by adding an order column to the relations table, but didn't want to get ahead of myself and add it as an AC.

@ktyjscott
Copy link

@gabestein i believe this is the mock you're thinking of? https://www.figma.com/design/SqOTMElJn7fuPljfQL1gIY/PubPub-Platform?node-id=1713-26642&t=WZo7NPAY2HnIi87k-1

Let me know if you think this meets the requirement - if not i can get it updated/add a new one to reflect what we need.

@gabestein
Copy link
Member Author

Oh nice, yup that's it! Thanks!

@gabestein gabestein changed the title Ability to add existing pubs as relations in forms Input component for adding existing pubs as relations in forms Jan 13, 2025
@gabestein gabestein moved this from Ready to In Progress in PubPub Legacy & Platform Combined Workstreams Jan 13, 2025
@allisonking allisonking linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants