From f6288718bc5941609ff4e6d70c1a7a1dc234b8c1 Mon Sep 17 00:00:00 2001
From: Carolyn Cole <cac9@princeton.edu>
Date: Fri, 10 Sep 2021 10:43:45 -0400
Subject: [PATCH] Remove source from requests urls

---
 app/services/physical_holdings_markup_builder.rb       | 8 ++++----
 spec/javascript/orangelight/availability.spec.js       | 6 +++---
 spec/services/physical_holdings_markup_builder_spec.rb | 2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/services/physical_holdings_markup_builder.rb b/app/services/physical_holdings_markup_builder.rb
index b06d2b4d3..1251d86f1 100644
--- a/app/services/physical_holdings_markup_builder.rb
+++ b/app/services/physical_holdings_markup_builder.rb
@@ -268,26 +268,26 @@ def self.request_placeholder(adapter, holding_id, location_rules, holding)
     link = if !location_rules.nil? && /^scsb.+/ =~ location_rules['code']
              if scsb_supervised_items?(holding)
                link_to('Reading Room Request',
-                       "/requests/#{doc_id}?source=pulsearch",
+                       "/requests/#{doc_id}",
                        title: 'Request to view in Reading Room',
                        class: 'request btn btn-xs btn-primary',
                        data: { toggle: 'tooltip' })
              else
                link_to(request_label(location_rules),
-                       "/requests/#{doc_id}?source=pulsearch",
+                       "/requests/#{doc_id}",
                        title: request_tooltip(location_rules),
                        class: 'request btn btn-xs btn-primary',
                        data: { toggle: 'tooltip' })
              end
            elsif !adapter.voyager_holding?(holding_id)
              link_to('Reading Room Request',
-                     "/requests/#{doc_id}?mfhd=#{holding_id}&source=pulsearch",
+                     "/requests/#{doc_id}?mfhd=#{holding_id}",
                      title: 'Request to view in Reading Room',
                      class: 'request btn btn-xs btn-primary',
                      data: { toggle: 'tooltip' })
            else
              link_to(request_label(location_rules),
-                     "/requests/#{doc_id}?mfhd=#{holding_id}&source=pulsearch",
+                     "/requests/#{doc_id}?mfhd=#{holding_id}",
                      title: request_tooltip(location_rules),
                      class: 'request btn btn-xs btn-primary',
                      data: { toggle: 'tooltip' })
diff --git a/spec/javascript/orangelight/availability.spec.js b/spec/javascript/orangelight/availability.spec.js
index 8f440df3b..12150e410 100644
--- a/spec/javascript/orangelight/availability.spec.js
+++ b/spec/javascript/orangelight/availability.spec.js
@@ -461,7 +461,7 @@ describe('AvailabilityUpdater', function() {
       '      <span class="availability-icon badge badge-secondary" title=""></span>' +
       '    </td>' +
       '    <td class="location-services service-conditional" data-open="false" data-requestable="true" data-aeon="false" data-holding-id="22555592710006421">' +
-      '     <a title="View Options to Request copies from this Location" class="request btn btn-xs btn-primary" data-toggle="tooltip" href="/requests/99101378413506421?mfhd=22555592710006421&amp;source=pulsearch">Request</a>' +
+      '     <a title="View Options to Request copies from this Location" class="request btn btn-xs btn-primary" data-toggle="tooltip" href="/requests/99101378413506421?mfhd=22555592710006421">Request</a>' +
       '    </td>' +
       '    <td class="holding-details">' +
       '      <ul class="item-status" data-record-id="99101378413506421" data-holding-id="22555592710006421"></ul>' +
@@ -595,7 +595,7 @@ describe('AvailabilityUpdater', function() {
       '            <td class="location-services service-conditional" data-open="true" data-requestable="true" data-aeon="false"' +
       '                data-holding-id="22614245530006421"><a title="View Options to Request copies from this Location"' +
       '                    class="request btn btn-xs btn-primary" data-toggle="tooltip"' +
-      '                    href="/requests/99115992283506421?mfhd=22614245530006421&amp;source=pulsearch">Request</a></td>' +
+      '                    href="/requests/99115992283506421?mfhd=22614245530006421">Request</a></td>' +
       '            <td class="holding-details">' +
       '                <ul class="item-status" data-record-id="99115992283506421" data-holding-id="22614245530006421"></ul>' +
       '            </td>' +
@@ -613,7 +613,7 @@ describe('AvailabilityUpdater', function() {
       '                data-aeon="false" data-holding-id="22614245510006421"><a' +
       '                    title="View Options to Request copies from this Location" class="request btn btn-xs btn-primary"' +
       '                    data-toggle="tooltip"' +
-      '                    href="/requests/99115992283506421?mfhd=22614245510006421&amp;source=pulsearch">Request</a></td>' +
+      '                    href="/requests/99115992283506421?mfhd=22614245510006421">Request</a></td>' +
       '            <td class="holding-details">' +
       '                <ul class="item-status" data-record-id="99115992283506421" data-holding-id="22614245510006421"></ul>' +
       '            </td>' +
diff --git a/spec/services/physical_holdings_markup_builder_spec.rb b/spec/services/physical_holdings_markup_builder_spec.rb
index 0f98637b3..cd893cb98 100644
--- a/spec/services/physical_holdings_markup_builder_spec.rb
+++ b/spec/services/physical_holdings_markup_builder_spec.rb
@@ -219,7 +219,7 @@
       expect(request_placeholder_markup).to include 'data-aeon="false"'
       expect(request_placeholder_markup).to include 'data-holding-id="3668455"'
       expect(request_placeholder_markup).to include '<a title="View Options to Request copies from this Location"'
-      expect(request_placeholder_markup).to include 'href="/requests/123456?mfhd=3668455&amp;source=pulsearch"'
+      expect(request_placeholder_markup).to include 'href="/requests/123456?mfhd=3668455"'
     end
   end