Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs building easier #26

Closed
bmbouter opened this issue Aug 19, 2022 · 2 comments
Closed

Make docs building easier #26

bmbouter opened this issue Aug 19, 2022 · 2 comments

Comments

@bmbouter
Copy link
Member

Right now you can build docs with:

oci-env shell
pip install -r /src/pulpcore/doc_requirements.txt
cd /src/pulpcore/docs
make diagrams html

It would be great if:

  • There was an easy command to install the doc_requirements
  • There was an easy way to call the make file command (passing through the args to make would be ideal)
@newswangerd
Copy link
Collaborator

Some notes on how to implement this, if anyone wants to give it a shot:

I would recommend creating a oci-env docs subcommand. I don't know enough about how docs work in pulp to make recommendations how how this command should work other than it might be a good idea to follow the patterns for the oci-env test command.

Possible usage for the docs subcommmand:

# Install the doc dependencies for PLUGIN_NAME and run COMMAND for that plugin's makefile
oci-env docs -i -p PLUGIN_NAME COMMAND

# Run COMMAND for that PLUGIN_NAME's docs makefile without installing docs dependencies
oci-env docs -p PLUGIN_NAME COMMAND

@lubosmj
Copy link
Member

lubosmj commented Oct 8, 2024

The section for docs building was already improved:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants